Fix e2e tests broken in #17865 #19009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,7 +118,7 @@ func verifyResult(c *client.Client, podName string, ns string) { | |||
| "involvedObject.kind": "Pod", | |||
| "involvedObject.name": podName, | |||
| "involvedObject.namespace": ns, | |||
| "source": "scheduler", | |||
| "source": api.DefaultSchedulerName, | |||
There was a problem hiding this comment.
I think we shouldn't change this one, since this is about 1.0 branch, which didn't change.
fgrzadkowski
force-pushed
the
fix_e2e
branch
from
17c5fb1 to
4ee0e7e
Compare
|
@wojtek-t Done. PTAL |
k8s-github-robot
added
the
size/XS
|
Labelling this PR as size/XS |
wojtek-t
added
the
lgtm
|
LGTM |
fgrzadkowski
added a commit
that referenced
this pull request
Dec 22, 2015
Fix e2e tests broken in #17865
|
GCE e2e build/test failed for commit 4ee0e7e. |
|
GCE e2e test build/test passed for commit 17c5fb10375957dbe60334b6b992559484f9d4a1. |
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
May 22, 2018
Differentiate liveness and readiness probes for router pods Origin-commit: 13d42ec71f692b7b35b5efdd32c86b3df73e410e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was broken in #17865
@davidopp @HaiyangDING - FYI