Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close watchers in tests #18999

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Conversation

wojtek-t
Copy link
Member

Ref #18928

@wojtek-t
Copy link
Member Author

@k8s-bot unit test this please

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 22, 2015
@wojtek-t
Copy link
Member Author

@k8s-bot unit test this please

@k8s-bot
Copy link

k8s-bot commented Dec 22, 2015

GCE e2e test build/test passed for commit 2b8854b.

@fgrzadkowski fgrzadkowski added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2015
@fgrzadkowski
Copy link
Contributor

Let's merge to see if this will improve unit tests with go1.5.

fgrzadkowski added a commit that referenced this pull request Dec 22, 2015
@fgrzadkowski fgrzadkowski merged commit 6ac2774 into kubernetes:master Dec 22, 2015
@wojtek-t wojtek-t deleted the close_watchers branch December 28, 2015 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants