Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config resource in env vars #18974

Merged
merged 2 commits into from
Jan 15, 2016
Merged

Config resource in env vars #18974

merged 2 commits into from
Jan 15, 2016

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented Dec 21, 2015

Depends on #18712

@k8s-github-robot
Copy link

Labelling this PR as size/XXL

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 21, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 21, 2015

GCE e2e test build/test passed for commit f56f43a7684d5e11c809ee276711ca77d2bd9431.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 5, 2016

GCE e2e test build/test passed for commit a0fbc69117c6e37e5b671c78ebb336fdaf73e5fb.

@pmorie
Copy link
Member Author

pmorie commented Jan 5, 2016

@k8s-bot unit test this

@k8s-bot
Copy link

k8s-bot commented Jan 5, 2016

GCE e2e test build/test passed for commit f5d1a97b5d6fcf40dc1a326c01da7665a1feb361.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 6, 2016

GCE e2e build/test failed for commit bb7ad4f69033f49d6665214cc43d4e024a4a7b03.

@k8s-bot
Copy link

k8s-bot commented Jan 6, 2016

GCE e2e test build/test passed for commit 91b33c7ed03ce4a8da1f6688af1d50cf16493e75.

@pmorie
Copy link
Member Author

pmorie commented Jan 6, 2016

@k8s-bot unit test this

@bgrant0607 bgrant0607 mentioned this pull request Jan 8, 2016
Merged
@bgrant0607 bgrant0607 assigned erictune and unassigned bgrant0607 Jan 8, 2016
@bgrant0607
Copy link
Member

Makes sense for the same person to review this as #18298

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2016
@pmorie pmorie changed the title WIP: Config resource in env vars Config resource in env vars Jan 14, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 14, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 14, 2016

GCE e2e test build/test passed for commit 17c8c8f.

@pmorie
Copy link
Member Author

pmorie commented Jan 14, 2016

@erictune ready for review; PTAL

@erictune
Copy link
Member

LGTM

@erictune erictune added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2016
@erictune
Copy link
Member

feel free to reapply LGTM after rebase.

@pmorie
Copy link
Member Author

pmorie commented Jan 14, 2016

@erictune thanks for the review! ✊

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jan 15, 2016

GCE e2e test build/test passed for commit 17c8c8f.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jan 15, 2016

GCE e2e test build/test passed for commit 17c8c8f.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Jan 15, 2016
Merge pull request #18974 from pmorie/config-env
21aa683 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 21aa683 into kubernetes:master Jan 15, 2016
@pmorie
Copy link
Member Author

pmorie commented Jan 15, 2016

@erictune thanks again for the tune-up

This was referenced Jan 16, 2016
Closed
Merged
@erictune
Copy link
Member

🎵 ⬆️

@pmorie
Copy link
Member Author

pmorie commented Jan 19, 2016

🎵 ⬆️

I lol'd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erictune erictune

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pmorie @k8s-github-robot @k8s-bot @bgrant0607 @erictune @k8s-teamcity-mesosphere @googlebot