Slice conversion requires destination package #18918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
GCE e2e test build/test passed for commit 1737180. |
|
@k8s-bot unit test this |
1 similar comment
|
@k8s-bot unit test this |
|
LGTM - thanks for the fix! |
wojtek-t
added
the
lgtm
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e test build/test passed for commit 1737180. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 1737180. |
|
@k8s-bot unit test this please |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 1737180. |
|
@k8s-bot unit test this please |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 22, 2015
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we writeConversionForSlice, we use the outField type name to
instantiate the make(...) call (runtime.RawExtension). Currently
runtime.RawExtension is shielded from exposing this bug because it
is hardcoded - the upcoming codec split exposes it. We need to record
import for the package path of the out slice conversion so that
when we write the conversion function the package is imported.