Minimize log level for request backoffs #18858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
cc @krousey also happy to delete the log, but figured id propose this first. |
|
GCE e2e test build/test passed for commit 3d0c385dc1a40268a0a4afc7326d16b22800350b. |
|
@k8s-bot test this please |
|
GCE e2e test build/test passed for commit 3d0c385dc1a40268a0a4afc7326d16b22800350b. |
jayunit100
force-pushed
the
overlogging-rclient
branch
from
3d0c385 to
c2982e8
Compare
|
To simplify ive just deleted the logs entirely. Also removed an excess blank line here. |
|
GCE e2e build/test failed for commit c2982e826c7e25b4ae50cbda075329fe61ed336d. |
|
@jayunit100 - can you please fix: |
…ents, from overlogging.
jayunit100
force-pushed
the
overlogging-rclient
branch
from
c2982e8 to
4891d82
Compare
|
ah, yup. done. |
|
GCE e2e test build/test passed for commit 4891d82. |
wojtek-t
added
the
lgtm
|
LGTM |
mikedanese
added a commit
that referenced
this pull request
Dec 22, 2015
Minimize log level for request backoffs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18796 so that logs only will be created if running at high verbosity.
I can delete it if we really want... but the logs will trail off after startup either way...