Add support for 3rd party objects to kubectl #18835
Conversation
|
Labelling this PR as size/L |
k8s-github-robot
added
needs-rebase
|
GCE e2e build/test failed for commit 199926c05554a22edfd73d3199c325cea4c128ae. |
k8s-github-robot
removed
the
needs-rebase
brendandburns
force-pushed
the
3rdparty
branch
from
199926c to
9cacb46
Compare
|
GCE e2e build/test failed for commit 9cacb46f0bc2b3d296849ea6fd2262f2d844739b. |
brendandburns
force-pushed
the
3rdparty
branch
from
9cacb46 to
ade3e4e
Compare
| Resources map[string]unversioned.GroupVersionKind | ||
| } | ||
|
|
||
| func interfacesFor(version string) (*meta.VersionInterfaces, error) { |
There was a problem hiding this comment.
I don't see this used anywhere.
|
Second commit mostly lgtm. Not familiar enough with master/apiserver to comment on the first one. |
|
GCE e2e build/test failed for commit ade3e4e6b77c6ca483698502ed1983fee76fb70d. |
brendandburns
force-pushed
the
3rdparty
branch
2 times, most recently
from
b36e0bd to
eb88094
Compare
|
@jlowdermilk comments addressed. second commit is the only one for review, the first commit is covered in: #18484 |
|
lgtm |
k8s-github-robot
added
the
needs-rebase
| clientVersions = append(clientVersions, registered.RegisteredGroupVersions[ix]) | ||
| } | ||
| // Add in any third party group/version resources | ||
| list, err := gvClient.ThirdPartyResources(api.NamespaceDefault).List(api.ListOptions{}) |
There was a problem hiding this comment.
forbidden's from this API request should be handled gracefully. I don't think I'd expect the whole method to fail.
brendandburns
force-pushed
the
3rdparty
branch
from
eb88094 to
c06eaf9
Compare
k8s-github-robot
removed
the
needs-rebase
| return priorityRESTMapper, api.Scheme | ||
| // return outputRESTMapper, api.Scheme |
There was a problem hiding this comment.
Could you remove these two lines?
|
GCE e2e build/test passed for commit 6d4fbe9fe5d6d52d870365822c5377603aa8f8eb. |
|
@caesarxuchao comments addressed, please take another look. Thanks! |
|
GCE e2e build/test passed for commit 79f0b45df212671647863f138ba851f4e0d6f3f9. |
|
GCE e2e build/test passed for commit be6c5b3. |
|
@caesarxuchao comments addressed and all green. Any chance for an LGTM? this one is a bear to keep in sync. |
|
Thanks @brendandburns. LGTM. We can incrementally fix the left issues. |
caesarxuchao
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit be6c5b3. |
| cfg, err := clientConfig.ClientConfig() | ||
| CheckErr(err) | ||
| cmdApiVersion := unversioned.GroupVersion{} | ||
| if cfg.GroupVersion != nil { | ||
| cmdApiVersion = *cfg.GroupVersion | ||
| } | ||
| if discoverDynamicAPIs { |
There was a problem hiding this comment.
cc @krousey I think you'd be interested in this. This is building REST mapper (with the exisiting RESTMapper struct) based on discovery results.
eparis
added
the
release-note
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit be6c5b3. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit be6c5b3. |
|
Automatic merge from submit-queue |
@deads2k @jlowdermilk
Instructions for playing around with this:
Run an apiserver with third party resources turned on (
--runtime-config=extensions/v1beta1=true,extensions/v1beta1/thirdpartyresources=true)Then you should be able to:
{ "metadata": { "name": "foo.company.com" }, "apiVersion": "extensions/v1beta1", "kind": "ThirdPartyResource", "versions": [ { "apiGroup": "group", "name": "v1" }, { "apiGroup": "group", "name": "v2" } ] }Once that is done, you should be able to:
{ "kind": "Foo", "apiVersion": "company.com/v1", "metadata": { "name": "baz" }, "someField": "hello world", "otherField": 1 }After this PR, you can do:
etc.