Make kubelet handleRun work for pods in non-default namespace #1873
+17
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did this even work for the default namespace. Shouldn't it have had a path: like: |
|
LGTM, but would like @dchen1107 to look too. |
|
It worked because it always passed the default namespace when looking up the bound pod. There were a number of these placeholders that were blocked until the boundPods work went in. Sent from my iPhone
|
|
LGTM |
dchen1107
added a commit
that referenced
this pull request
Oct 17, 2014
…ace_aware Make kubelet handleRun work for pods in non-default namespace
deads2k
pushed a commit
to deads2k/kubernetes
that referenced
this pull request
Feb 13, 2024
…erry-pick-1871-to-release-4.15 [release-4.15] OCPBUGS-28209: UPSTREAM <carry>: use snyk file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated kubelet server to take a podNamespace as input.
Did not find any other internal callers of this in k8s, but if reviewer is aware of some, I can update.