Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unversioned selectors #18702

Merged
merged 1 commit into from
Dec 23, 2015
Merged

Remove unversioned selectors #18702

merged 1 commit into from
Dec 23, 2015
+0 −298

Conversation

wojtek-t
Copy link
Member

No description provided.

@wojtek-t wojtek-t self-assigned this Dec 15, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XL

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 15, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 15, 2015

GCE e2e test build/test passed for commit e562db63d1e8bf4edbefe67d3a81565357abd951.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2015
@wojtek-t wojtek-t force-pushed the remove_unversioned_selectors branch from e562db6 to 16a3849 Compare December 22, 2015 10:05
@k8s-github-robot k8s-github-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 22, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 22, 2015
@wojtek-t wojtek-t force-pushed the remove_unversioned_selectors branch from 16a3849 to 4aa2121 Compare December 22, 2015 10:07
@wojtek-t wojtek-t assigned smarterclayton and unassigned wojtek-t Dec 22, 2015
@wojtek-t
Copy link
Member Author

@smarterclayton - one more small cleanup PR - can you please take a look?

@k8s-bot
Copy link

k8s-bot commented Dec 22, 2015

GCE e2e test build/test passed for commit 16a3849bf30b11f87ec5f43a72eef51a6d48d465.

@k8s-bot
Copy link

k8s-bot commented Dec 22, 2015

GCE e2e test build/test passed for commit 4aa2121.

@wojtek-t
Copy link
Member Author

@k8s-bot unit test this please

2 similar comments
@wojtek-t
Copy link
Member Author

@k8s-bot unit test this please

@wojtek-t
Copy link
Member Author

@k8s-bot unit test this please

@smarterclayton
Copy link
Contributor

LGTM

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2015
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 23, 2015

GCE e2e build/test failed for commit 4aa2121.

@wojtek-t
Copy link
Member Author

@k8s-bot e2e test this please

@k8s-bot
Copy link

k8s-bot commented Dec 23, 2015

GCE e2e test build/test passed for commit 4aa2121.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 23, 2015

GCE e2e test build/test passed for commit 4aa2121.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@gmarek
Copy link
Contributor

gmarek commented Dec 23, 2015

@k8s-bot unit test this

@k8s-bot
Copy link

k8s-bot commented Dec 23, 2015

GCE e2e test build/test passed for commit 4aa2121.

@gmarek gmarek mentioned this pull request Dec 23, 2015
Closed
@gmarek
Copy link
Contributor

gmarek commented Dec 23, 2015

@k8s-bot unit test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 23, 2015

GCE e2e test build/test passed for commit 4aa2121.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 23, 2015
Merge pull request #18702 from wojtek-t/remove_unversioned_selectors
ac0ce72 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit ac0ce72 into kubernetes:master Dec 23, 2015
@wojtek-t wojtek-t deleted the remove_unversioned_selectors branch December 28, 2015 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wojtek-t @k8s-github-robot @k8s-bot @smarterclayton @gmarek @k8s-teamcity-mesosphere @googlebot