Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stop with delete command in e2e test #18636

Merged

Conversation

feihujiang
Copy link
Contributor

Stop command is marked as deprecated, we shouldn't use it.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 14, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 14, 2015

GCE e2e build/test failed for commit fd068b2.

@feihujiang
Copy link
Contributor Author

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Dec 14, 2015

GCE e2e build/test failed for commit fd068b2.

@feihujiang
Copy link
Contributor Author

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Dec 14, 2015

GCE e2e test build/test passed for commit fd068b2.

@wojtek-t wojtek-t assigned wojtek-t and unassigned ixdy Dec 15, 2015
@wojtek-t
Copy link
Member

LGTM - thanks!

@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2015
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Dec 16, 2015

GCE e2e build/test failed for commit fd068b2.

@wojtek-t
Copy link
Member

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Dec 16, 2015

GCE e2e test build/test passed for commit fd068b2.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 17, 2015
@k8s-github-robot k8s-github-robot merged commit 5f1ebc3 into kubernetes:master Dec 17, 2015
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 27, 2018
Automatic merge from submit-queue.

Picks for volume manager

Thanks to @jsafrane for these fixes

kubernetes#59873
kubernetes#59923

59923 modified from upstream because some logging levels where already higher in 1.9

xref https://bugzilla.redhat.com/show_bug.cgi?id=1538216

Fixes openshift/origin#17605
Fixes openshift/origin#17556

@derekwaynecarr

Origin-commit: e4f2115102c01124cc7f168b7f1ae4c65f190875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants