fix testcase in pkg/client/leaderelection that wasn't testing what it said it was testing #18589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… said it was testing
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
GCE e2e test build/test passed for commit 5e03250. |
|
LGTM. |
madhusudancs
added
the
lgtm
j3ffml
added a commit
that referenced
this pull request
Dec 11, 2015
fix testcase in pkg/client/leaderelection that wasn't testing what it said it was testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment says it's testing "acquire from led, unacked endpoints" but the first GET is returning an unled endpoints. It was a copy from the "acquire from unled endpoints" case.