Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change kubectl help/examples to use jsonpath instead of template #18533

Merged
merged 1 commit into from
Jan 29, 2016
Merged

Change kubectl help/examples to use jsonpath instead of template #18533

merged 1 commit into from
Jan 29, 2016
+10 −10

Conversation

j3ffml
Copy link
Contributor

@j3ffml j3ffml commented Dec 10, 2015

@kubernetes/kubectl

@j3ffml j3ffml added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 10, 2015
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 10, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-bot
Copy link

k8s-bot commented Dec 10, 2015

GCE e2e test build/test passed for commit db51981eb15e390c7767ee5f78d6d3ca4ea300b5.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2015
@j3ffml j3ffml removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 11, 2016

GCE e2e test build/test passed for commit 34e7f6826cca7317bdf18e871d752b48b034f2a7.

@j3ffml j3ffml assigned janetkuo and unassigned smarterclayton Jan 15, 2016
@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Jan 16, 2016

GCE e2e test build/test passed for commit 34e7f6826cca7317bdf18e871d752b48b034f2a7.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2016
@j3ffml j3ffml removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2016
@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2016
@j3ffml
Copy link
Contributor Author

j3ffml commented Jan 29, 2016

change was just rebase, re-adding label

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 29, 2016

GCE e2e test build/test passed for commit 734a8c0.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jan 29, 2016

GCE e2e test build/test passed for commit 734a8c0.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Jan 29, 2016
Merge pull request #18533 from jlowdermilk/kubectl-help
298028d 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 298028d into kubernetes:master Jan 29, 2016
@j3ffml j3ffml deleted the kubectl-help branch October 19, 2016 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janetkuo janetkuo

Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@j3ffml @k8s-github-robot @k8s-bot @k8s-teamcity-mesosphere @smarterclayton @janetkuo @googlebot