Added handling custom metrics to resource consumer. #18511
Merged
+112
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
the
size/L
|
Labelling this PR as size/L |
jszczepkowski
force-pushed
the
cm-consumer
branch
from
a6c4b96 to
4f7cf85
Compare
| fmt.Fprintf(w, "# TYPE %s gauge\n", k) | ||
| fmt.Fprintf(w, "%s %f\n", k, v) | ||
| } | ||
| handler.metricsLock.Unlock() |
There was a problem hiding this comment.
Move this to defer right after the line where the lock is acquired .
|
LGTM, just a small nit |
Added handling custom metrics in Prometheus format to resource consumer.
jszczepkowski
force-pushed
the
cm-consumer
branch
from
4f7cf85 to
aade6e7
Compare
|
GCE e2e test build/test passed for commit a6c4b961996aef2e77e5c910a0a22fc79a42ad24. |
|
PTAL |
piosz
added
lgtm
|
GCE e2e test build/test passed for commit 4f7cf8571989957bf9287368296071ef6c8b6797. |
|
GCE e2e test build/test passed for commit aade6e7. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 10, 2015
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling custom metrics in Prometheus format to resource consumer.