Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate design and user docs #1851

Merged
merged 1 commit into from
Oct 31, 2014
Merged

Conversation

erictune
Copy link
Member

Moved design documentation into a subdirectory.
Created some new user-focused documentation, and a glossary.
Partially resolves #1813

- **API documentation**
- in [api](../api)
- automatically generated REST API documentation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add links to the wiki, which contains the FAQs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added. Could not determine a pattern for what goes on wiki as opposed to somewhere else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't put the API change guidelines there.

As for the rest, I find it a PITA to submit a PR to add a single bullet item. I put the FAQs on the wiki so that I could immediately add FAQ bullets after answering questions on IRC. I put the Community and Media pages there for a similar reason -- when someone posted or Tweeted something, I could add a bullet. For the most part, this information isn't tightly coupled to the code. It's true that non-maintainers have no way of directly adding to the wiki, but they could file issues about the content.

@bgrant0607
Copy link
Member

Could you leave forwarding docs in place for the design docs that have been moved? I posted links to them in many places.

- in [api](../api)
- automatically generated REST API documentation
- **Wiki**
- at [https://github.com/GoogleCloudPlatform/kubernetes/wiki]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other bullets:

at [wiki](https://github.com/GoogleCloudPlatform/kubernetes/wiki)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@bgrant0607
Copy link
Member

Also, FYI/FWIW, I originally put the user documentation in the API documentation -- this was before the docs directory even existed IIRC.

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/api/kubernetes.raml

Probably whatever content is still useful should be eventually moved out of the .raml file, so feel free to copy anything that's useful.

@derekwaynecarr
Copy link
Member

This is cool. Do you have any ideas on where we can document internal APIs? For example, the kubelet, kube-proxy, etc. all have REST end-points that are undocumented, and I think developers looking to modify code in these areas are served well by some document that describes the internal non-public REST API.

@erictune
Copy link
Member Author

@derekwaynecarr put that stuff in docs/devel

@bgrant0607 bgrant0607 added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 21, 2014
@bgrant0607
Copy link
Member

@derekwaynecarr If you're asking about API documentation, @erictune is correct that the meat should be in docs/devel. For per-call documentation, we're investigating autogeneration: #1052.

@erictune
Copy link
Member Author

Added basic user docs for all moved docs except access.md and security.md.

@erictune
Copy link
Member Author

Copied api/kubernetes.raml documentation into docs/overview.md and updated it.

@erictune
Copy link
Member Author

@bgrant0607

I've responded to all your comments. I'd encourage you to accept this PR if you think it is a significant improvement, rather than if you think it is perfect.

@erictune
Copy link
Member Author

I'll squash when you say to.

@erictune
Copy link
Member Author

@bgrant0607 PTAL

- covers development conventions
- explains current architecture and project plans
- **Design Documentation**
- in [docs/devel](./design)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You meant docs/design

@bgrant0607
Copy link
Member

Very nice! Thanks a lot. A few minor fixes remaining.

@erictune
Copy link
Member Author

Thanks for careful review. All comments addressed in latest push.

@bgrant0607
Copy link
Member

Great. LGTM. Please squash.

Renamed: logging.md -> devel/logging.m
Renamed: access.md -> design/access.md
Renamed: identifiers.md -> design/identifiers.md
Renamed:    labels.md -> design/labels.md
Renamed:    namespaces.md -> design/namespaces.md
Renamed:    security.md -> design/security.md
Renamed:    networking.md -> design/networking.md

Added abbreviated user user-focused document in place of most moved docs.

Added docs/README.md explains how docs are organized.
Added short, user-oriented documentation on labels
Added a glossary.
Fixed up some links.
@erictune
Copy link
Member Author

squashed @bgrant0607

bgrant0607 added a commit that referenced this pull request Oct 31, 2014
Separate design and user docs
@bgrant0607 bgrant0607 merged commit e792248 into kubernetes:master Oct 31, 2014
@erictune erictune deleted the dev_doc branch November 2, 2014 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate design documentation from user documentation
3 participants