Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import util.sh and logging.sh since two functions are unbound #18472

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

mikedanese
Copy link
Member

No description provided.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2015
@mikedanese
Copy link
Member Author

https://github.com/kubernetes/kubernetes/blob/master/cluster/common.sh#L389-L390

kube::util::wait-for-job
and kube::log::error
are unbound in this context because i hastily didn't test my bash

@mikedanese
Copy link
Member Author

cc @madhusudancs

@mikedanese mikedanese closed this Dec 9, 2015
@mikedanese mikedanese reopened this Dec 9, 2015
@madhusudancs
Copy link
Contributor

LGTM

@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 9, 2015

GCE e2e build/test failed for commit 96d1b8d.

@mikedanese
Copy link
Member Author

@k8s-bot ok to test

@k8s-bot
Copy link

k8s-bot commented Dec 10, 2015

GCE e2e test build/test passed for commit 96d1b8d.

@mikedanese
Copy link
Member Author

@k8s-bot ok to test. build keeps timing out

@k8s-bot
Copy link

k8s-bot commented Dec 10, 2015

GCE e2e build/test failed for commit 96d1b8d.

@mikedanese
Copy link
Member Author

@k8s-bot ok to test

@k8s-bot
Copy link

k8s-bot commented Dec 10, 2015

GCE e2e test build/test passed for commit 96d1b8d.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 10, 2015
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit fda0f91 into kubernetes:master Dec 10, 2015
@mikedanese mikedanese deleted the unbound branch December 10, 2015 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants