MESOS: fix e2e Events [It] should be sent by kubelets and the scheduler about pods #18434
Conversation
s-urbaniak
force-pushed
the
sur-680-kubelet-events
branch
from
8384804 to
4cdb322
Compare
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
|
GCE e2e test build/test passed for commit 4cdb32254a3a4baf0341ae75bf139c0fe1e0c9c3. |
| // taken from KubeletServer#Run(*KubeletConfig) | ||
| clientConfig, err := s.CreateAPIServerClientConfig() | ||
| if err == nil { | ||
| kcfg.KubeClient, err = client.New(clientConfig) |
There was a problem hiding this comment.
if the intent is to create a separate client for events, then why overwrite kcfg.KubeClient here?
There was a problem hiding this comment.
i think you can just reuse apiclient here instead of creating a new client.Client. the bits you really need are below, creating the eventClientConfig and an EventClient.
There was a problem hiding this comment.
I literally copied this code 1:1 from upstream as suggested by @sttts, we had apiclient in the first place, but apiclient does not have those QPS and Burst settings.
Shall I still use apiclient?
There was a problem hiding this comment.
Re KubeClient, you're right, I shall remove the initialization here.
|
@jdef PTAL |
s-urbaniak
force-pushed
the
sur-680-kubelet-events
branch
from
e77bf42 to
7c33708
Compare
|
Labelling this PR as size/L |
k8s-github-robot
added
size/L
|
GCE e2e build/test failed for commit e77bf42f4174f35fe8d2da388acf77b052d11764. |
|
GCE e2e test build/test passed for commit 7c33708ac78d3427e01d68d1d753059ae6937676. |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
Kubelet events are not being tracked. This commit fixes it by initializing the event client. fixes d2iq-archive/kubernetes-mesos#680
s-urbaniak
force-pushed
the
sur-680-kubelet-events
branch
from
7c33708 to
9176e93
Compare
|
@jdef squashed, ready to merge :-) |
|
lgtm |
jdef
added
lgtm
jdef
changed the title
jdef
changed the title
jdef
changed the title
|
GCE e2e test build/test passed for commit 9176e93. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
…vents Auto commit by PR queue bot
…vents Auto commit by PR queue bot
No description provided.