Change instruction for Mac OS X users running local docker cluster. #18433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
|
GCE e2e test build/test passed for commit e3a2f0e. |
|
The port-forwarding also apparently didn't work well with docker machine. |
|
I haven't tested this out, but the change sounds good to me. |
|
LGTM. Though it might be nice to indicate how you could find that address (e.g. |
brendandburns
added
the
lgtm
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 10, 2015
Auto commit by PR queue bot
|
@brendandburns I addressed your comment in #18510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we required port forwarding via ssh to the docker VM. I think it's easier to just use different IP address in kubectl configuration and skip this part of the guide.
@brendandburns @mikedanese @roberthbailey
Ref #12722