Remove some prerequisites from single node docker cluster setup instructions. #18430
Conversation
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
|
GCE e2e test build/test passed for commit a5b2a7b8a1eac8e11555d73246cd456ab35c84a2. |
|
I don't think this information should be removed totally. |
| @@ -55,35 +55,7 @@ Here's a diagram of what the final result will look like: | |||
| ### Prerequisites | |||
|
|
|||
| 1. You need to have docker installed on one machine. | |||
| 2. Your kernel should support memory and swap accounting. Ensure that the | |||
There was a problem hiding this comment.
How about keeping this around for folks who have their nodes in-correctly configured. This information could reside in a Troubleshooting section for example :)
There was a problem hiding this comment.
I agree . This shouldn't be removed completely, but we can move it to the troubleshooting section.
There was a problem hiding this comment.
I'm fine with moving this to Troubleshooting section. I just don't want to discourage people by seeing and reading a long and complicated list of kernel options.
fgrzadkowski
force-pushed
the
simpler_prerequisites
branch
from
a5b2a7b to
b17c1cb
Compare
|
@vishh Moved memsg/swap instructions to troubleshooting. PTAL. |
|
GCE e2e test build/test passed for commit b17c1cb. |
|
Thanks @fgrzadkowski! These doc improvements are super helpful 💯 |
vishh
added
the
lgtm
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Automatic merge from submit-queue (batch tested with PRs 18666, 18810, 18430, 18517, 18653). UPSTREAM: 59316: Exit if no client cert is available for 5m Origin-commit: 0a8f794ba7c989ae6b798604f366d9ffb191ab98
This is part of #18351.
Understanding and verifying those prerequisites is hard and according to @vishh now we will generate events and Node will be reported as NotReady (see #9837 (comment))
@asridharan @brendandburns