Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up Pod docs a bit #18419

Merged
merged 1 commit into from
Dec 10, 2015
Merged

Tidy up Pod docs a bit #18419

merged 1 commit into from
Dec 10, 2015

Conversation

thockin
Copy link
Member

@thockin thockin commented Dec 9, 2015

In response to a user question I wanted to point them to a doc, but this doc
was a little hard to digest. I did not do the whole doc, just the first sections which seemed most introductory. I could do the rest.

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 9, 2015

GCE e2e build/test failed for commit 025dfe5050bd25b09cdbf1cff5e2bc3985b40dc3.

@@ -50,42 +50,92 @@ Documentation for other releases can be found at

<!-- END MUNGE: GENERATED_TOC -->

In Kubernetes, rather than individual application containers, _pods_ are the smallest deployable units that can be created, scheduled, and managed.
_pods_ are the smallest deployable units that can be created and managed in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pods cause a program to run. If you don't know anything about kbernetes, you might not get "compute" out of this sentence (or the old one).

@erictune
Copy link
Member

erictune commented Dec 9, 2015

LGTM. I have some optional suggestions.

@erictune erictune added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2015
@thockin
Copy link
Member Author

thockin commented Dec 9, 2015

All comments addressed, I think

On Wed, Dec 9, 2015 at 1:46 PM, Eric Tune notifications@github.com wrote:

LGTM. I have some optional suggestions.


Reply to this email directly or view it on GitHub
#18419 (comment)
.

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2015
@erictune erictune added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Dec 9, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 10, 2015

GCE e2e build/test failed for commit d8c42b0.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 10, 2015
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit c6cb9d7 into kubernetes:master Dec 10, 2015
@thockin thockin deleted the pod-doc branch December 14, 2015 16:51
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 27, 2018
Automatic merge from submit-queue (batch tested with PRs 18415, 18419, 18268, 18102, 18440).

update glide.yaml and rebump deps to stay current

We had a new fork, 11 out of date forks, and a half-dozen repos needing pinning.

/assign @enj
@mfojtik how is that bot coming?

Origin-commit: 9a0806a2ee5e45f5bbb88ffa806f92f3a28066dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants