Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --config=/etc/kubernetes/manifests to kubelet #18398

Merged

Conversation

mamikonyana
Copy link
Contributor

This adds --config option to the parameters of ubuntu deploy script, solves #18397

@k8s-bot
Copy link

k8s-bot commented Dec 8, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Dec 8, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2015
@mikedanese
Copy link
Member

LGTM

@mikedanese
Copy link
Member

cc @dalanlan

@mikedanese mikedanese added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Dec 9, 2015
@k8s-github-robot
Copy link

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Dec 9, 2015

GCE e2e build/test failed for commit 6932136.

@dalanlan
Copy link
Contributor

dalanlan commented Dec 9, 2015

It might worth making --config a configurable param.

@eparis
Copy link
Contributor

eparis commented Dec 9, 2015

@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Dec 9, 2015

GCE e2e test build/test passed for commit 6932136.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 9, 2015
@k8s-github-robot k8s-github-robot merged commit 5b24758 into kubernetes:master Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants