-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gcloud install instead of gcloud update for components to remove the annoying prompt #18377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the annoying prompt. Fixes kubernetes#18374
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Dec 8, 2015
j3ffml
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Dec 8, 2015
GCE e2e test build/test passed for commit 48a84ba. |
I'm merging this thing manually. It's really annoying. |
zmerlynn
added a commit
that referenced
this pull request
Dec 9, 2015
Use gcloud install instead of gcloud update for components to remove the annoying prompt
I found it annoying too. Hence the quick turn-around on getting out a CL after filing the issue. 😄 |
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Feb 27, 2018
Automatic merge from submit-queue (batch tested with PRs 18390, 18389, 18290, 18377, 18385). UPSTREAM: <carry>: hack out the oapi for restmapping resources when m… …ore than one is present If there is more than one kind or resource for a value (the CLI uses this for deciding what to do about deploymentconfigs as a for instance), anything in that list that is an openshift resource (I've only listed one to prove the concept), will be removed. I think that referencing names from a file will still work since that should come back with one match. @juanvallejo can you see if files containing oapi resources still work. @soltysh @mfojtik @smarterclayton is this a thing we can live with? It will finally make the groupified resources have priority on the CLI. @DirectXMan12 I really wish this had not worked. Origin-commit: 1fef218f66e095364185af65409ec7c85e4fb590
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Feb 27, 2018
…-sadness-electric-boogaloo Automatic merge from submit-queue. UPSTREAM: <carry>: Short-circuit HPA oapi/v1.DC The legacy oapi v1 group-version very much confuses anything not designed to explicitly work with it. Since we now don't do any custom HPA setup, we need to teach the scale client and the HPA what to do with the oapi version of DC, since it won't even show up in its discovery process. Related to kubernetes#18377 Origin-commit: 3c18cd314df92f4e1d6c3d2d9e575232edb7fd9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18374