Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gcloud install instead of gcloud update for components to remove the annoying prompt #18377

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

roberthbailey
Copy link
Contributor

Fixes #18374

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 8, 2015
@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 8, 2015

GCE e2e test build/test passed for commit 48a84ba.

@zmerlynn
Copy link
Member

zmerlynn commented Dec 9, 2015

I'm merging this thing manually. It's really annoying.

zmerlynn added a commit that referenced this pull request Dec 9, 2015
Use gcloud install instead of gcloud update for components to remove the annoying prompt
@zmerlynn zmerlynn merged commit f1f250c into kubernetes:master Dec 9, 2015
@roberthbailey
Copy link
Contributor Author

I found it annoying too. Hence the quick turn-around on getting out a CL after filing the issue. 😄

@roberthbailey roberthbailey deleted the gcloud-prompts branch January 26, 2016 21:22
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 27, 2018
Automatic merge from submit-queue (batch tested with PRs 18390, 18389, 18290, 18377, 18385).

UPSTREAM: <carry>: hack out the oapi for restmapping resources when m…

…ore than one is present

If there is more than one kind or resource for a value (the CLI uses this for deciding what to do about deploymentconfigs as a for instance), anything in that list that is an openshift resource (I've only listed one to prove the concept), will be removed.

I think that referencing names from a file will still work since that should come back with one match.

@juanvallejo can you see if files containing oapi resources still work.
@soltysh @mfojtik @smarterclayton is this a thing we can live with? It will finally make the groupified resources have priority on the CLI.
@DirectXMan12 I really wish this had not worked.

Origin-commit: 1fef218f66e095364185af65409ec7c85e4fb590
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 27, 2018
…-sadness-electric-boogaloo

Automatic merge from submit-queue.

UPSTREAM: <carry>: Short-circuit HPA oapi/v1.DC

The legacy oapi v1 group-version very much confuses anything not
designed to explicitly work with it.  Since we now don't do any custom
HPA setup, we need to teach the scale client and the HPA what to do
with the oapi version of DC, since it won't even show up in its
discovery process.

Related to kubernetes#18377

Origin-commit: 3c18cd314df92f4e1d6c3d2d9e575232edb7fd9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants