Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote string to preserve newlines in output in list-resources script #18376

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Quote string to preserve newlines in output in list-resources script #18376

merged 1 commit into from
Dec 9, 2015

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Dec 8, 2015

Some missing quotes were causing output from gcloud to get squashed on one line, e.g.

[ disks ]
Attempt 1 to list disks in GCE
NAME ZONE SIZE_GB TYPE STATUS e2e-gce-master-1-991eb2fd-9b1f-11e5-a592-42010af0226b us-central1-f 10 pd-standard READY e2e-gce-master-1-master us-central1-f 10 pd-standard READY e2e-gce-master-1-master-pd us-central1-f 20 pd-ssd READY e2e-gce-master-1-minion-7s3f us-central1-f 100 pd-standard READY e2e-gce-master-1-minion-c44b us-central1-f 100 pd-standard READY e2e-gce-master-1-minion-ekva us-central1-f 100 pd-standard READY e2e-gce-master-1-minion-i2b4 us-central1-f 100 pd-standard READY e2e-gce-master-1-minion-q9ai us-central1-f 100 pd-standard READY e2e-gce-master-1-minion-xlqw us-central1-f 100 pd-standard READY

This was likely to make diffing more useless.

By simply quoting the string passed to echo, the newlines are preserved.

@ixdy ixdy mentioned this pull request Dec 8, 2015
Closed
@roberthbailey roberthbailey self-assigned this Dec 8, 2015
@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2015
@roberthbailey
Copy link
Contributor

LGTM.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-bot
Copy link

k8s-bot commented Dec 8, 2015

GCE e2e build/test failed for commit 96f302d.

@wojtek-t
Copy link
Member

wojtek-t commented Dec 9, 2015

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Dec 9, 2015

GCE e2e test build/test passed for commit 96f302d.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 9, 2015
Merge pull request #18376 from ixdy/list-resources-script
8925098 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 8925098 into kubernetes:master Dec 9, 2015
@ixdy ixdy deleted the list-resources-script branch August 13, 2016 00:21
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 27, 2018
@k8s-publishing-bot
Merge pull request kubernetes#18376 from deads2k/cli-17-autoscale
5a79f17 
Automatic merge from submit-queue (batch tested with PRs 18376, 18355).

UPSTREAM: <carry>: hack in working autoscale reference for oc autoscale

I lost your bugzilla.  This adds a nasty hack to recognize that we need to specify a different group for autoscaling DCs.

/assign @DirectXMan12
/assign @juanvallejo

Origin-commit: 7a6d8cd8e493d984a3bbd515568dafc998d6d185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ixdy @roberthbailey @k8s-github-robot @k8s-bot @wojtek-t @k8s-teamcity-mesosphere @googlebot