update test to pass properly and reflect actual behavior #18356
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
|
GCE e2e build/test failed for commit f2b73d0b85ee2abb475176ad85e53399a66fb11f. |
|
no way a unit test change broken e2e @k8s-bot test this please |
|
GCE e2e build/test failed for commit f2b73d0b85ee2abb475176ad85e53399a66fb11f. |
deads2k
force-pushed
the
make-broken-test-correct
branch
from
f2b73d0 to
7118f90
Compare
|
GCE e2e build/test failed for commit 7118f90. |
|
No code changed. @k8s-bot test this please |
|
GCE e2e test build/test passed for commit 7118f90. |
|
LGTM. |
brendandburns
added
the
lgtm
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 11, 2015
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code was always erroring and simply returning the default, "I failed" output, which happened to pass the test. This tightens the handling to fail on errors and updates the test case to reflect what's actually happening.
Kinds are expected to singular, not plural.
@janetkuo I think you wrote the original test: https://github.com/kubernetes/kubernetes/pull/10652/files#diff-c9c115e8b8a40ad87d50a100d746b178R147.