Fix bug when getting new RC of a deployment #18331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetkuo
added
kind/bug
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
Sorry I have made the same mistake everywhere :) We should also cherrypick these to release-1.1. |
nikhiljindal
added
the
lgtm
|
@nikhiljindal okay I will cherrypick both. :) |
|
GCE e2e build/test failed for commit 72bd4e8. |
|
@k8s-bot e2e test this |
|
GCE e2e test build/test passed for commit 72bd4e8. |
This was referenced Dec 9, 2015
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e test build/test passed for commit 72bd4e8. |
nikhiljindal
added a commit
that referenced
this pull request
Dec 10, 2015
Fix bug when getting new RC of a deployment
j3ffml
added a commit
that referenced
this pull request
Dec 11, 2015
…31-upstream-release-1.1 Automated cherry pick of #18331 upstream release 1.1
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#18331-upstream-release-1.1 Automated cherry pick of kubernetes#18331 upstream release 1.1
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…ck-of-#18331-upstream-release-1.1 Automated cherry pick of kubernetes#18331 upstream release 1.1
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Jan 31, 2018
Automatic merge from submit-queue (batch tested with PRs 18225, 18351, 18331, 18340, 18326). UPSTREAM: 57854: fix bug of swallowing missing merge key error fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1529659 Origin-commit: db03c4980ab2a7c4d1cd85ca0cf9bb1b3e5411d7
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Feb 27, 2018
Automatic merge from submit-queue (batch tested with PRs 18225, 18351, 18331, 18340, 18326). UPSTREAM: 57854: fix bug of swallowing missing merge key error fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1529659 Origin-commit: db03c4980ab2a7c4d1cd85ca0cf9bb1b3e5411d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #18321.
cc @nikhiljindal @lavalamp @kubernetes/sig-config