kubelet: Small refactor on GetPhase() #18237
Conversation
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
| failed++ | ||
| } | ||
| case containerStatus.State.Waiting != nil: | ||
| if containerStatus.LastTerminationState.Terminated != nil { |
There was a problem hiding this comment.
The definition of stopped is unclear at best. I think #17971 also needs to be clearly defined...
There was a problem hiding this comment.
Yeah...I'm totally confused now...Why the waiting container should be calculated as stopped here? @yujuhong
There was a problem hiding this comment.
Because they are in the crashloop backoff state :-(
There was a problem hiding this comment.
Ah...I didn't read the following code just now...Thanks! :)
|
GCE e2e build/test failed for commit db4b7b10bc5397173abd51a3286374bbe1068d5d. |
Random-Liu
added
the
lgtm
|
@yifan-gu LGTM. Switch is really cleaner than if-else chain (I just took a Golang class today, the teacher also taught us this, hahaha) |
|
@k8s-bot test this |
|
GCE e2e test build/test passed for commit db4b7b10bc5397173abd51a3286374bbe1068d5d. |
Random-Liu
changed the title
yifan-gu
force-pushed
the
refactor_getphase
branch
from
db4b7b1 to
4ac6129
Compare
|
@Random-Liu Thanks for fixing the title :) I fixed the commit title as well. |
|
PR changed after LGTM, removing LGTM. |
k8s-github-robot
removed
the
lgtm
Random-Liu
added
the
lgtm
|
GCE e2e test build/test passed for commit 4ac6129. |
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e test build/test passed for commit 4ac6129. |
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e test build/test passed for commit 4ac6129. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 4ac6129. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Automatic merge from submit-queue (batch tested with PRs 18237, 18586, 18578). UPSTREAM: 58685: Fill size attribute for the OpenStack V3 API volumes The getVolume method in OpenStack provider is not filling the Size for the V3 API type volumes. This breaks the PV resizing of Cinder volumes which compares the existing volume size with the new request. This leads to redundant volume resize calls to the cloud provider that end with errors. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535314 Origin-commit: 0ea2737d4d4112ece8f6616e108867a46d85ae37
cc @dchen1107 @yujuhong @Random-Liu @timstclair