Getting Started Guide style update #18181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't indent top-level lists - Use 2 space list item indentation, unless using multi-line items, then use 4 space indents - Use underline for page title - Auto-generate table of contents - Start with lvl 2 headers (lvl 1 headers look too much like the page title)
karlkfi
added
kind/documentation
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
GCE e2e build/test failed for commit c3c7c81. |
|
e2e flake or bug in master: |
This was referenced Dec 4, 2015
|
This will need to be cherry-picked to release-1.1 and then the gh-pages updated in order to get this to kubernetes.io |
|
Since this modifies the guide readme, can you take a look @bgrant0607 ? The changes are pretty trivial, just style and formatting. I wasn't ambitious enough to refactor all the docs... |
|
lgtm |
erictune
added
the
lgtm
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 8, 2015
Auto commit by PR queue bot
k8s-github-robot
referenced
this pull request
Dec 9, 2015
…8181-upstream-release-1.1 Auto commit by PR queue bot
karlkfi
pushed a commit
to mesosphere-backup/kubernetes
that referenced
this pull request
Dec 9, 2015
s-urbaniak
pushed a commit
to mesosphere-backup/kubernetes
that referenced
this pull request
Dec 10, 2015
Auto commit by PR queue bot
shyamjvs
referenced
this pull request
in shyamjvs/kubernetes
Dec 1, 2016
…pick-of-#18181-upstream-release-1.1 Auto commit by PR queue bot
shouhong
referenced
this pull request
in shouhong/kubernetes
Feb 14, 2017
…pick-of-#18181-upstream-release-1.1 Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 4-space list indent is critical to how redcarpet renders lists as html on kubernetes.io. The rest are just for stylistic consistency.