-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minion->Node rename: docs/ machine names only, except gce/aws for #1111 #18177
Minion->Node rename: docs/ machine names only, except gce/aws for #1111 #18177
Conversation
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Labelling this PR as size/L |
@smarterclayton Can you please review or reassign this? Thanks! |
@bgrant0607 @thockin Hi Tim and/or Brian, can you look at this PR? It's yet another boring really simple minion->node for # 1111. No code, just markdown docs. I've gotten no response from the assignee for a week. Thank you |
@thockin Thanks! |
No, thank you! when the last "minion" is gone we'll have a party. On Thu, Dec 10, 2015 at 9:04 PM, Brad Erickson notifications@github.com
|
GCE e2e test build/test passed for commit ac5726a. |
Automatic merge from submit-queue |
Auto commit by PR queue bot
Auto commit by PR queue bot
Auto commit by PR queue bot
Auto commit by PR queue bot
Yet another in the long line of exciting changes for the technical debt issue #1111, this renames all server/machine names in
/docs
:-minion-
,minion-
,-minion
. Markdown files only,e2e-not-required
.Note: it's not just a simple sed, because extra spaces/tabs are required to keep text alignments.
I've excluded aws and gce because those should be handled when the specific providers are addressed. Only
/docs
and machine names to keep the number of changed lines lower for ease of review, avoidsize/XL
+ labels, and make other following pull requests easier.