Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minion->Node rename: docs/ machine names only, except gce/aws for #1111 #18177

Merged
merged 1 commit into from
Dec 11, 2015
Merged

Minion->Node rename: docs/ machine names only, except gce/aws for #1111 #18177

merged 1 commit into from
Dec 11, 2015

Conversation

13rac1
Copy link
Contributor

@13rac1 13rac1 commented Dec 3, 2015

Yet another in the long line of exciting changes for the technical debt issue #1111, this renames all server/machine names in /docs: -minion-, minion-, -minion. Markdown files only, e2e-not-required.

Note: it's not just a simple sed, because extra spaces/tabs are required to keep text alignments.

I've excluded aws and gce because those should be handled when the specific providers are addressed. Only /docs and machine names to keep the number of changed lines lower for ease of review, avoid size/XL+ labels, and make other following pull requests easier.

@k8s-bot
Copy link

k8s-bot commented Dec 3, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Dec 3, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added the kind/design Categorizes issue or PR as related to design. label Dec 3, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 3, 2015
@13rac1 13rac1 changed the title Minion->Node rename: docs/ machine names only, except gce/aws Minion->Node rename: docs/ machine names only, except gce/aws for #1111 Dec 5, 2015
@13rac1
Copy link
Contributor Author

13rac1 commented Dec 8, 2015

@smarterclayton Can you please review or reassign this? Thanks!

@13rac1
Copy link
Contributor Author

13rac1 commented Dec 11, 2015

@bgrant0607 @thockin Hi Tim and/or Brian, can you look at this PR? It's yet another boring really simple minion->node for # 1111. No code, just markdown docs. I've gotten no response from the assignee for a week. Thank you

@thockin thockin added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Dec 11, 2015
@thockin thockin assigned thockin and unassigned smarterclayton Dec 11, 2015
@k8s-github-robot
Copy link

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@13rac1
Copy link
Contributor Author

13rac1 commented Dec 11, 2015

@thockin Thanks!

@thockin
Copy link
Member

thockin commented Dec 11, 2015

No, thank you! when the last "minion" is gone we'll have a party.

On Thu, Dec 10, 2015 at 9:04 PM, Brad Erickson notifications@github.com
wrote:

@thockin https://github.com/thockin Thanks!


Reply to this email directly or view it on GitHub
#18177 (comment)
.

@k8s-bot
Copy link

k8s-bot commented Dec 11, 2015

GCE e2e test build/test passed for commit ac5726a.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 11, 2015
@k8s-github-robot k8s-github-robot merged commit 4a22f2f into kubernetes:master Dec 11, 2015
@13rac1 13rac1 deleted the 1111-doc-machine-names branch December 11, 2015 05:50
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants