Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete sentinel.py from redis example #18141

Merged
merged 1 commit into from
Dec 6, 2015

Conversation

tback
Copy link
Contributor

@tback tback commented Dec 3, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Dec 3, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Dec 3, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@tback
Copy link
Contributor Author

tback commented Dec 3, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2015
@tback
Copy link
Contributor Author

tback commented Dec 3, 2015

Before this change the image failed to build because sentinel.py is absent.

@brendandburns
Copy link
Contributor

LGTM, thanks for the fix!

@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Dec 5, 2015
@k8s-github-robot
Copy link

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e build/test failed for commit c022bd0.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@wojtek-t
Copy link
Member

wojtek-t commented Dec 5, 2015

@k8s-bot e2e test this please

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e build/test failed for commit c022bd0.

@wojtek-t
Copy link
Member

wojtek-t commented Dec 6, 2015

@k8s-bot e2e test this please

@k8s-bot
Copy link

k8s-bot commented Dec 6, 2015

GCE e2e test build/test passed for commit c022bd0.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 6, 2015
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 0e3f962 into kubernetes:master Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants