Removing duplicate NewEtcdStorage code #18136
Merged
+51
−326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
GCE e2e test build/test passed for commit 870463e14a0b83ea9f91902e1785cb1bc4e17160. |
nikhiljindal
force-pushed
the
del-new-etcd-storage
branch
from
870463e to
7112317
Compare
| if err != nil { | ||
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
| etcdStorage := framework.NewEtcdStorage() |
There was a problem hiding this comment.
It seems that this one (and the following lines, e.g. the whole storageDestinations-related code) is no longer needed.
Can you please remove it?
|
@nikhiljindal - great cleanup - thanks! I added some comments to remove some more no-longer needed code. |
|
GCE e2e test build/test passed for commit 7112317c809d8a7fd7c2006ab9edc3619d3b89b9. |
nikhiljindal
force-pushed
the
del-new-etcd-storage
branch
from
7112317 to
5c556ba
Compare
|
Thanks @wojtek-t |
|
Great - thanks! LGTM |
wojtek-t
added
lgtm
|
Travis continuous integration appears to have missed, closing and re-opening to trigger it |
|
GCE e2e test build/test passed for commit 5c556ba. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 3, 2015
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from #18113
Removing NewEtcdStorage method from master and replacing its callers by etcdstorage.NewEtcdStorage() which does the same thing.
cc @caesarxuchao @wojtek-t