deprecate confusing flag usage for --bind-address for api-server
#18128
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
GCE e2e test build/test passed for commit e2cf9c87021509e7d8d420a18d8cbb2590982dcb. |
|
GCE e2e test build/test passed for commit 87f901d12aedbe5764d09681d1834af2c14a2a71. |
| @@ -185,7 +185,7 @@ func (s *APIServer) AddFlags(fs *pflag.FlagSet) { | |||
| fs.IPVar(&s.InsecureBindAddress, "address", s.InsecureBindAddress, "DEPRECATED: see --insecure-bind-address instead") | |||
| fs.MarkDeprecated("address", "see --insecure-bind-address instead") | |||
| fs.IPVar(&s.BindAddress, "bind-address", s.BindAddress, ""+ | |||
| "The IP address on which to serve the --read-only-port and --secure-port ports. The "+ | |||
| "The IP address on which to serve the --secure-port ports. The "+ | |||
There was a problem hiding this comment.
Hm, is "The IP address on which to listen for the --secure-port." more readable?
|
GCE e2e build/test failed for commit 387d861. |
|
@lavalamp Comment addressed. |
lavalamp
added
e2e-not-required
lgtm
|
lgtm |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 7, 2015
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18049