Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update client.Request for GroupVersion #18022

Merged
merged 1 commit into from
Dec 6, 2015
Merged

update client.Request for GroupVersion #18022

merged 1 commit into from
Dec 6, 2015

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 1, 2015

Plumbs GroupVersion down into our RESTClient

ref: #17216

@liggitt @caesarxuchao

@deads2k deads2k mentioned this pull request Dec 1, 2015
Closed
61 tasks
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added kind/new-api size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 1, 2015

GCE e2e test build/test passed for commit c83f281c675ae86a2d418c21b7f166a39fcb00f3.

@caesarxuchao
Copy link
Member

LGTM. Thanks.

@caesarxuchao caesarxuchao added lgtm "Looks good to me", indicates that a PR is ready to be merged. cla: yes and removed cla: yes labels Dec 1, 2015
@ncdc
Copy link
Member

ncdc commented Dec 2, 2015

cc @kubernetes/rh-cluster-infra

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2015
@wojtek-t
Copy link
Member

wojtek-t commented Dec 3, 2015

@deads2k - can you please rebase?

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 3, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 3, 2015

GCE e2e test build/test passed for commit 0fd17b7.

@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2015
@k8s-github-robot
Copy link

Travis continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e test build/test passed for commit 0fd17b7.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e test build/test passed for commit 0fd17b7.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 6, 2015

GCE e2e test build/test passed for commit 0fd17b7.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 6, 2015
Merge pull request #18022 from deads2k/gv-request
c6b5935 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit c6b5935 into kubernetes:master Dec 6, 2015
@deads2k deads2k deleted the gv-request branch February 26, 2016 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@deads2k @k8s-github-robot @k8s-bot @caesarxuchao @ncdc @wojtek-t @k8s-teamcity-mesosphere @googlebot