ubuntu: skip binaries downloading if specified version exists #18002
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
|
I have already signed CLA. Can anybody tell why googlebot thinks I did not sign the agreement? |
|
The google bot compares the e-mail listed in the commit message with the e-mail that signed the CLA. |
|
I guess it is also possible that the bot gets confused because your git commit has an e-mail but no name. Instead of the typical |
|
@dalanlan your thoughts? |
|
ok, thank you for your answer. I will try next time 2015-12-01 23:49 GMT+08:00 Eric Paris notifications@github.com:
|
| mkdir -p binaries/master | ||
| mkdir -p binaries/minion | ||
|
|
||
| # flannel | ||
| FLANNEL_VERSION=${FLANNEL_VERSION:-"0.5.3"} | ||
| echo "Prepare flannel ${FLANNEL_VERSION} release ..." | ||
| if [ ! -f flannel.tar.gz ] ; then | ||
| grep -q "^$FLANNEL_VERSION\$" binaries/.flannel 2>/dev/null || { |
There was a problem hiding this comment.
Sorry, I don't understand. Where to add braces?
There was a problem hiding this comment.
${FLANNEL_VERSION}
Mainly a style thing.
|
Thanks for fixing this. Only a few nits. |
|
Could you squash and make sure the author information is correct so the cla bot will be good? It seems that the author is good for the second commit, but not for the original. Thank you! |
|
@k8s-bot ok to test |
|
GCE e2e test build/test passed for commit bdceb9ce52f459985c23066da01c69680ee784d8. |
|
CLAs look good, thanks! |
|
GCE e2e test build/test passed for commit c55ab7d. |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
eparis
added
lgtm
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Automatic merge from submit-queue. UPSTREAM: 56506: kubelet: include runtime error in event on CreatePodSandbox failure kubernetes#56506 xref https://bugzilla.redhat.com/show_bug.cgi?id=1506813 Origin-commit: 3d701d8b932b32e9a8f335f6f1a79d8084dca75f
Sometimes we need to run
kube-up.shagain and again when something wrong. We should skip downloading binaries if the specified version already exists.