-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue# 17860 Correct expression of nodecontroller for sync loop in no… #17924
Conversation
…de.html 1. Remove "creates" from the sentence 2. Add general explaination for nodecontaoller kubernetes#17860
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Labelling this PR as size/XS |
Have submitted my CLA using the correct email already. |
This looks good. You need to have your email in your github account I think. |
@brendandburns Yes, I have already add my email in my github account. And with CLA signed. Not sure what to do next? |
@brendandburns How should I do next? Any suggestion? |
@xinxiaogang I don't see your email when I look at your profile, so maybe it's not public? I manually validate the CLA for this PR, but we should figure out why the automation doesn't see it. Also you need to run:
|
…de.html 1. Remove "creates" from the sentence 2. Add general explaination for nodecontaoller kubernetes#17860
@brendandburns I have my email configured in my profile as below: |
@xinxiaogang odd, when I look at https://github.com/xinxiaogang I don't see your mail, but when I look at https://github.com/brendandburns I see mine, so I think something must not be quite right? |
@k8s-bot ok to test |
GCE e2e test build/test passed for commit 83df275. |
@k8s-bot unit test this please |
Automatic merge from submit-queue |
Auto commit by PR queue bot
…de.html
#17860