Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue# 17860 Correct expression of nodecontroller for sync loop in no… #17924

Merged
merged 5 commits into from
Dec 10, 2015

Conversation

xinxiaogang
Copy link
Contributor

…de.html

  1. Remove "creates" from the sentence
  2. Add general explaination for nodecontaoller

#17860

…de.html

1. Remove "creates" from the sentence
2. Add general explaination for nodecontaoller

kubernetes#17860
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2015
@xinxiaogang
Copy link
Contributor Author

Have submitted my CLA using the correct email already.

@brendandburns
Copy link
Contributor

This looks good. You need to have your email in your github account I think.

@xinxiaogang
Copy link
Contributor Author

@brendandburns Yes, I have already add my email in my github account. And with CLA signed. Not sure what to do next?

@xinxiaogang
Copy link
Contributor Author

@brendandburns How should I do next? Any suggestion?

@brendandburns
Copy link
Contributor

@xinxiaogang I don't see your email when I look at your profile, so maybe it's not public?

I manually validate the CLA for this PR, but we should figure out why the automation doesn't see it.

Also you need to run:

hack/update-generated-docs.sh

Xin added 2 commits December 3, 2015 09:20
@xinxiaogang
Copy link
Contributor Author

@brendandburns I have my email configured in my profile as below:
xnxin@ebay.com Primary Public
Is this correct?

@brendandburns
Copy link
Contributor

@xinxiaogang odd, when I look at https://github.com/xinxiaogang

I don't see your mail, but when I look at https://github.com/brendandburns

I see mine, so I think something must not be quite right?

@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Dec 10, 2015
@brendandburns
Copy link
Contributor

@k8s-bot ok to test

@k8s-github-robot
Copy link

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Dec 10, 2015

GCE e2e test build/test passed for commit 83df275.

@wojtek-t
Copy link
Member

@k8s-bot unit test this please

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 10, 2015
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 2a5e83a into kubernetes:master Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants