Fix frequent kubernetes endpoint updates during cluster start #17920
Conversation
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
abutcher
force-pushed
the
check-endpoints
branch
from
0c8411f to
94a7f3a
Compare
|
Labelling this PR as size/M |
k8s-github-robot
added
size/M
|
@k8s-bot ok to test |
|
LGTM. would like a second, though. |
|
GCE e2e test build/test passed for commit 94a7f3a7f5894328cbc74fd22b3876a8bd17bf66. |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
|
I think I have managed to convince myself that this will work. If there are fewer than expected, there is no truncation, and so the trimming stuff shouldn't be necessary. |
|
Please update the comment above the function to clarify the return values. |
abutcher
force-pushed
the
check-endpoints
branch
from
94a7f3a to
36d4c8b
Compare
|
@brendandburns Comment updated lmk if that format is okay |
…s than or equal to master count. checkEndpointSubsetFormat ensures that, 1. the current master's IP is in the list of addresses 2. the number of IPs in the list exactly matches the master count This is problematic while masters are in the process of starting because it causes frequent updates to the kubernetes endpoints until all masters have started and added themselves to the list. checkEndpointSubsetFormat should report success if the current master's IP is found and the count of addresses is less than or equal to the expected count.
abutcher
force-pushed
the
check-endpoints
branch
from
36d4c8b to
101a992
Compare
|
GCE e2e test build/test passed for commit 36d4c8b7b1176197d4bdc78573f27c6ad68e4fd0. |
|
GCE e2e test build/test passed for commit 101a992. |
brendandburns
added
ok-to-merge
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 101a992. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
checkEndpointSubsetFormat ensures that,
This is problematic while masters are in the process of starting because it causes frequent updates to the kubernetes endpoints until all masters have started and added themselves to the list.
checkEndpointSubsetFormat should report success if the current master's IP is found and the count of addresses is less than or equal to the expected count.
/cc @liggitt
openshift/origin#6073