Add a tool for monitoring log generation rates #17880
Conversation
|
Labelling this PR as size/L |
k8s-github-robot
added
needs-rebase
gmarek
force-pushed
the
log_monitoring
branch
2 times, most recently
from
d1c9d96 to
c6a4c95
Compare
k8s-github-robot
removed
the
needs-rebase
|
GCE e2e test build/test passed for commit 5f6a666453481fcb2b7632727940dd963dcbc042. |
|
GCE e2e test build/test passed for commit c6a4c95e91d97d5055c359081a5c559b6eeb16be. |
|
GCE e2e test build/test passed for commit d1c9d969d8d28ff803d7239c525b3ccd43d7df5b. |
gmarek
force-pushed
the
log_monitoring
branch
from
c6a4c95 to
aba4dca
Compare
|
GCE e2e build/test failed for commit aba4dca76e41e63397b506d036417dd9aaf9a354. |
gmarek
force-pushed
the
log_monitoring
branch
from
aba4dca to
3223695
Compare
|
GCE e2e test build/test passed for commit 3223695ed7f7acbe2112b7c208c530c4a5d9a432. |
| @@ -89,6 +89,7 @@ func init() { | |||
| flag.BoolVar(&testContext.DeleteNamespace, "delete-namespace", true, "If true tests will delete namespace after completion. It is only designed to make debugging easier, DO NOT turn it off by default.") | |||
| flag.BoolVar(&testContext.CleanStart, "clean-start", false, "If true, purge all namespaces except default and system before running tests. This serves to cleanup test namespaces from failed/interrupted e2e runs in a long-lived cluster.") | |||
| flag.BoolVar(&testContext.GatherKubeSystemResourceUsageData, "gather-resource-usage", false, "If set to true framework will be monitoring resource usage of system add-ons in (some) e2e tests.") | |||
| flag.BoolVar(&testContext.GatherLogSizes, "gather-logs-sizes", false, "If set to true framework will be monitoring logs sizes on all machines running e2e tests.") | |||
There was a problem hiding this comment.
Can you please be consistent: either logs or log everywhere
gmarek
force-pushed
the
log_monitoring
branch
from
3223695 to
5e80cfe
Compare
|
GCE e2e test build/test passed for commit 5e80cfe067052dec2ba1bc4ac38c5f0a66f43c84. |
| client *client.Client | ||
| closeChannel chan bool | ||
| data map[string]map[string]*LogsSizeData | ||
| lock *sync.Mutex |
There was a problem hiding this comment.
Why pointer to mutex, not just mutex?
Same for WaitGroup and below...
There was a problem hiding this comment.
It made a constructor a bit nicer IMO.
gmarek
force-pushed
the
log_monitoring
branch
2 times, most recently
from
7cc6cf0 to
8daa21e
Compare
|
GCE e2e test build/test passed for commit 7cc6cf08604038dc57fe3b6a27a3345608764b3d. |
|
GCE e2e build/test failed for commit 8daa21ef1cb6a2d5b260cbd7f050511acf00f31f. |
| apiServerLogsPath, controllersLogsPath, schedulerLogsPath} | ||
| ) | ||
|
|
||
| // LogsSizeData keeps whole timesries of TimestampedSize. |
gmarek
force-pushed
the
log_monitoring
branch
from
8daa21e to
d897b9c
Compare
|
GCE e2e test build/test passed for commit d897b9c2e6698302adf3c1c4857aef4ddf31c781. |
| } | ||
|
|
||
| type LogsSizeData struct { | ||
| data map[string]map[string]*[]TimestampedSize |
There was a problem hiding this comment.
Why do you need pointer to array here, i.e. why not just:
map[string]map[string][]TimestampedSize
?
There was a problem hiding this comment.
I'm not sure how 'immutable' are maps when it comes to slices...
gmarek
force-pushed
the
log_monitoring
branch
from
d897b9c to
6ade0a1
Compare
|
GCE e2e test build/test passed for commit 6ade0a1. |
|
LGTM |
wojtek-t
added
the
lgtm
|
Continuous integration appears to have missed, closing and re-opening to trigger it |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 6ade0a1. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Ref. #17879
cc @wojtek-t @brendandburns @davidopp @fgrzadkowski @lavalamp @timothysc @spiffxp