adding service account to libvirt #17848
Conversation
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
|
GCE e2e test build/test passed for commit 1affd2d72edab4710b072630a9dd95c564161fad. |
|
@zmerlynn have you time for this? |
|
@lavalamp @nikhiljindal may you have a look at this (feel free to reassign)? |
|
Or maybe @liggitt? |
| @@ -51,6 +52,19 @@ function detect-nodes { | |||
| KUBE_NODE_IP_ADDRESSES=("${NODE_IPS[@]}") | |||
| } | |||
|
|
|||
| function set_service_accounts { | |||
| SERVICE_ACCOUNT_KEY=${SERVICE_ACCOUNT_KEY:-"/tmp/kube-serviceaccount.key"} | |||
There was a problem hiding this comment.
will /tmp be writeable under normal circumstances?
There was a problem hiding this comment.
This env is local dev environment. /tmp in general is writable (as in local cluster)
|
@lhuard1A can you take a pass on these changes as well? |
sdminonne
force-pushed
the
libvirt_service_account
branch
from
1affd2d to
87b516b
Compare
|
@derekwaynecarr: removed NamespaceAutoProvision and @liggitt's feedback on double quoting. Squashed. Waiting @lhuard1A feedback |
|
GCE e2e test build/test passed for commit 87b516bad786231f9d6f169ef5919e05533bc0d8. |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
|
@derekwaynecarr : I had a look at @sdminonne’s change. |
sdminonne
force-pushed
the
libvirt_service_account
branch
from
87b516b to
ea1c97c
Compare
|
Labelling this PR as size/M |
k8s-github-robot
added
size/M
|
GCE e2e build/test failed for commit ea1c97c. |
|
This failure is a flake. @liggitt @derekwaynecarr as soon you're OK may you re-run the tests? Thanks |
|
GCE e2e build/test failed for commit ea1c97c. |
|
Reopened to have re-run tests |
|
@derekwaynecarr @liggitt can you help me with this? I'd like to have this merged |
derekwaynecarr
added
e2e-not-required
lgtm
|
@sdminonne - LGTM, tagged, and marked e2e-not-required get through the queue. |
|
@derekwaynecarr thanks |
|
@k8s-bot test this please |
|
GCE e2e test build/test passed for commit ea1c97c. |
|
@k8s-bot unit test this please |
1 similar comment
|
@k8s-bot unit test this please |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
No description provided.