Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documents for release process #17777

Merged
merged 1 commit into from
Dec 11, 2015

Conversation

fgrzadkowski
Copy link
Contributor

Some minor changes to the release process documents which were not obvious after I did the release.

@quinton-hoole

@fgrzadkowski fgrzadkowski added area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject labels Nov 25, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 25, 2015

GCE e2e test build/test passed for commit 4b7177151eecbfd4caf0680457deceadd1abbc9e.

1. find the appropriate `kubernetes.tar.gz` in GCS, download it, double check
the hash (compare to what you had in the release notes draft), and attach it
to the release; and
1. find the appropriate `kubernetes.tar.gz` in [GCS bucket](https://pantheon.corp.google.com/storage/browser/kubernetes-release/release/),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care that this link is public?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. Its's public anyway.

@ikehz
Copy link
Contributor

ikehz commented Nov 25, 2015

LGTM once comment is addressed; @fgrzadkowski please feel free to apply LGTM label once you've addressed that comment.

@ikehz
Copy link
Contributor

ikehz commented Nov 25, 2015

Thanks for the fixups!

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e test build/test passed for commit 4b7177151eecbfd4caf0680457deceadd1abbc9e.

@ikehz
Copy link
Contributor

ikehz commented Dec 3, 2015

Ping @fgrzadkowski.

@ikehz
Copy link
Contributor

ikehz commented Dec 3, 2015

Can you also add a conditional for alpha releases so that RELEASE_BRANCH gets set to master, so the docs are correctly pointed at HEAD of master, per @bgrant0607?

@ikehz
Copy link
Contributor

ikehz commented Dec 7, 2015

Ping @fgrzadkowski!

@ikehz ikehz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 10, 2015

GCE e2e test build/test passed for commit af49d0c90e4ab1998755c83494c804a05c4bc9da.

@k8s-bot
Copy link

k8s-bot commented Dec 10, 2015

GCE e2e test build/test passed for commit ee9a779.

@ikehz
Copy link
Contributor

ikehz commented Dec 11, 2015

@k8s-bot unit test this please

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 11, 2015
@k8s-github-robot k8s-github-robot merged commit dc88f18 into kubernetes:master Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants