Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing space #17663

Merged
merged 1 commit into from
Nov 24, 2015
Merged

remove trailing space #17663

merged 1 commit into from
Nov 24, 2015

Conversation

yanns
Copy link
Contributor

@yanns yanns commented Nov 23, 2015

the trailing space break the command in zsh at least

the trailing space break the command in zsh at least
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Nov 23, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@yanns
Copy link
Contributor Author

yanns commented Nov 23, 2015

I signed it!

@k8s-bot
Copy link

k8s-bot commented Nov 23, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@googlebot
Copy link

CLAs look good, thanks!

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2015
@wojtek-t wojtek-t assigned wojtek-t and unassigned bgrant0607 Nov 24, 2015
@wojtek-t wojtek-t added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Nov 24, 2015
@wojtek-t
Copy link
Member

LGTM

@wojtek-t wojtek-t closed this Nov 24, 2015
@wojtek-t wojtek-t reopened this Nov 24, 2015
@k8s-github-robot
Copy link

@k8s-bot ok to test

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-bot
Copy link

k8s-bot commented Nov 24, 2015

GCE e2e test build/test passed for commit 63e7a5e.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 24, 2015
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 2ddc61e into kubernetes:master Nov 24, 2015
@yanns yanns deleted the patch-1 branch November 25, 2015 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants