Ubuntu provider - can't set docker opts or complete install #17615
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
|
It sounds like I should be covered under the Hewlett Packard Enterprise CLA. |
|
@robdaemon Are you insist on enable Personally, I would prefer a debug mode, but not sure if I asked too much :) |
|
@resouer I don't mind doing it as a debug mode instead. I put -x because it helped me find the root cause of the problem to begin with. I can rework that part if you'd like. |
|
Yes, please do it :) |
robdaemon
force-pushed
the
source-config-default
branch
from
fe12e44 to
0d33281
Compare
|
Labelling this PR as size/M |
k8s-github-robot
added
size/M
|
@resouer Okay, added the DEBUG flag as you requested! |
| @@ -71,3 +71,4 @@ ENABLE_CLUSTER_UI="${KUBE_ENABLE_CLUSTER_UI:-true}" | |||
| # Add envitonment variable separated with blank space like "http_proxy=http://10.x.x.x:8080 https_proxy=https://10.x.x.x:8443" | |||
| PROXY_SETTING=${PROXY_SETTING:-""} | |||
|
|
|||
| DEBUG=${DEBUG:-"false"} | |||
|
Thanks! Just a few nits. And please sign your CLA :) |
robdaemon
force-pushed
the
source-config-default
branch
from
0d33281 to
0f853e7
Compare
|
I've signed the CLA - it's through the Hewlett Packard Enterprise corporate CLA :) |
|
CLAs look good, thanks! |
robdaemon
force-pushed
the
source-config-default
branch
from
0f853e7 to
77499d2
Compare
|
@resouer - feedback integrated, CLA in-place, this should be ready now? |
|
ping @zmerlynn |
k8s-github-robot
added
the
needs-rebase
|
@robdaemon Rebase needed;-) |
|
ping @robdaemon |
…efault/docker file, otherwise the DOCKER_OPTS set there do not get applied to new minion nodes.
When PROXY_SETTING is empty, you end up an empty
command of "", as witnessed by this bash debug
output when +x is enabled:
+ '' /home/ubuntu/kube/make-ca-cert.sh 10.0.0.232 IP:10.0.0.232,IP:192.168.3.1,DNS:kubernetes,DNS:kubernetes.default,DNS:kubernetes.default.svc,DNS:kubernetes.default.svc.cluster.local
Given the example:
PROXY_SETTING="http_proxy=http://server:port https_proxy=https://server:port"
You would not want this quoted on the script executed
on the remote master or minion node.
Enabling +e, for additional tracing and to
abort on any failure in the remote SSH session.
Adding a DEBUG parameter into config-default.sh allowing additional
debug information to be present in the logs during node rollout, using
bash's "set -x" when DEBUG=true
robdaemon
force-pushed
the
source-config-default
branch
from
77499d2 to
ebeb7bc
Compare
|
@dalanlan sorry about the delay, this is rebased now. |
k8s-github-robot
removed
the
needs-rebase
|
ping @zmerlynn |
zmerlynn
added
the
lgtm
|
GCE e2e test build/test passed for commit ebeb7bc. |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test failed for commit ebeb7bc. |
|
@k8s-bot test this |
|
GCE e2e test build/test passed for commit ebeb7bc. |
|
GCE e2e test build/test passed for commit ebeb7bc. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit ebeb7bc. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Setting custom DOCKER_OPTS so that you can use a private registry isn't working - the config-default.sh file needs to be sourced so it's visible when the /etc/default/docker file is written.
Additionally, the recent change to add quoting to PROXY_SETTING is not allowing the certificates to be created, which breaks cluster creation. The apiserver never starts because it's missing its certificates.