Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESOS: update known issues #17589

Merged

Conversation

jdef
Copy link
Contributor

@jdef jdef commented Nov 20, 2015

@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2015
@@ -1,34 +1,120 @@
## Known Issues
## DCOS Package Known Issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's super confusing have this as the page title when not all of the issues are DCOS specific.

It'd be ideal to just have a "Known Issues" page title, folowed bya table of contents that shows that there are general issues followed by dcos-specific issues. Thent he DCOS section can say that all of the general issues apply, and these additional issues also apply.

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e test build/test passed for commit b815269d75d21c46633f86ea6925bcaad93f25b2.

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e test build/test passed for commit 041c84183df29d63acfe273b055ec1fab7c4f7a3.

@karlkfi
Copy link
Contributor

karlkfi commented Nov 20, 2015

The ports stuff is kinda complicated. I'd really like to be able to easily answer from the user's perspective "What do I need to do about it?" for services, pods, and mesos slaves. The services section is really clear with the what and the how, without getting too deep into the why. I want something similar for pod config and mesos-slave config. The why should still be in the doc, but you don't want to get to the ports section and see the why first, see a giant list of long bullet points and not know what to do about it.


#### Runtime Configuration

- mesos: `--offer_timeout` : Duration of time before an offer is rescinded from a framework.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--offer-timeout? Didn't check, but I guess it's with a dash as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-bot
Copy link

k8s-bot commented Nov 23, 2015

GCE e2e test build/test passed for commit f36cb1383bd74bbd22471083d77de5a6cc4aac5d.

- availability of a resource offer that "fits" the pod (mesos master/slave);
- scheduler *backoff* (to avoid busy-looping) during pod scheduling (k8s-mesos scheduler)

We have tried to mitigate the second item by cancelling the backoff period if an offer arrives that fits a pod-in-waiting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "we", third person.

@s-urbaniak
Copy link
Contributor

@jdef left some nit comments, thanks for providing this!

@k8s-bot
Copy link

k8s-bot commented Nov 24, 2015

GCE e2e test build/test passed for commit de0c4f90e6e7a384003aaeb2d81368572359c990.

@sttts
Copy link
Contributor

sttts commented Nov 25, 2015

lgtm. please squash

- flag corrections
- split into general vs. DCOS known issues
- added lots of missing docs re: services, endpoints, upgrades,
  scheduler
- clarified pod/ports section
- cross-referenced open github issues where applicable
@jdef jdef force-pushed the jdef_better_known_issues branch from de0c4f9 to e5b8095 Compare November 25, 2015 15:10
@jdef jdef changed the title WIP/MESOS: update known issues MESOS: update known issues Nov 25, 2015
@jdef jdef added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2015
@jdef
Copy link
Contributor Author

jdef commented Nov 25, 2015

squished

@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-bot
Copy link

k8s-bot commented Nov 25, 2015

GCE e2e test build/test passed for commit e5b8095.

@jdef
Copy link
Contributor Author

jdef commented Nov 25, 2015

thanks @wojtek-t I didn't realize that label was there!

@wojtek-t
Copy link
Member

@jdef - we are using "e2e-not-required" label for all PRs that cannot affect tests that are running as part of PR builder tests (in particular docs-only changes, etc.)

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 25, 2015
@k8s-github-robot k8s-github-robot merged commit a873a43 into kubernetes:master Nov 25, 2015
sttts pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Nov 26, 2015
sttts pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Nov 30, 2015
s-urbaniak pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Dec 10, 2015
jdef pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform/mesos kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants