-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins: Run slow tests for Trusty in dedicated jobs #17465
Jenkins: Run slow tests for Trusty in dedicated jobs #17465
Conversation
Take slow tests out of release jobs because they are flaky and not as critical as the rest of the release tests. Also update the name of the release job for Trusy beta to kubernetes-e2e-gce-trusty-beta-release.
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
image_index="trusty-beta" | ||
elif [[ "${job_name}" =~ trusty ]]; then | ||
image_index="trusty" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why cannot we use the same test image for both jobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because they are testing different versions of the image.
Labelling this PR as size/M |
The motivation of this PR is reasonable. Currently the trusty Jenkins jobs run slow tests. When comparing the result with the test from ContainerVM, we are not comparing apple to apple. With this change, we are getting closer to a fair comparison. |
add to whitelist |
lgtm |
GCE e2e build/test failed for commit afa12c5. |
This change does not touch any test code or critical test setup, so it's unlikely the culprit for the test failures. |
Yeah, I'm seeing lots of pods failures today and I don't know why. @k8s-bot e2e test this |
GCE e2e build/test failed for commit afa12c5. |
@k8s-bot e2e test this please |
GCE e2e test build/test passed for commit afa12c5. |
Automatic merge from submit-queue |
Auto commit by PR queue bot
Take slow tests out of release jobs because they are flaky and not as critical
as the rest of the release tests.
Also update the name of the release job for Trusy beta to
kubernetes-e2e-gce-trusty-beta-release.
Tested on internal Jenkins. @ixdy @andyzheng0831