Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins: Run slow tests for Trusty in dedicated jobs #17465

Merged

Conversation

wonderfly
Copy link
Contributor

Take slow tests out of release jobs because they are flaky and not as critical
as the rest of the release tests.

Also update the name of the release job for Trusy beta to
kubernetes-e2e-gce-trusty-beta-release.

Tested on internal Jenkins. @ixdy @andyzheng0831

Take slow tests out of release jobs because they are flaky and not as critical
as the rest of the release tests.

Also update the name of the release job for Trusy beta to
kubernetes-e2e-gce-trusty-beta-release.
@k8s-bot
Copy link

k8s-bot commented Nov 18, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Nov 18, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

image_index="trusty-beta"
elif [[ "${job_name}" =~ trusty ]]; then
image_index="trusty"
fi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why cannot we use the same test image for both jobs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because they are testing different versions of the image.

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2015
@andyzheng0831
Copy link

The motivation of this PR is reasonable. Currently the trusty Jenkins jobs run slow tests. When comparing the result with the test from ContainerVM, we are not comparing apple to apple. With this change, we are getting closer to a fair comparison.

@ixdy
Copy link
Member

ixdy commented Nov 18, 2015

add to whitelist

@ixdy
Copy link
Member

ixdy commented Nov 19, 2015

lgtm

@ixdy ixdy added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Nov 19, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 19, 2015

GCE e2e build/test failed for commit afa12c5.

@wonderfly
Copy link
Contributor Author

This change does not touch any test code or critical test setup, so it's unlikely the culprit for the test failures.

@lavalamp lavalamp assigned ixdy and unassigned lavalamp Nov 19, 2015
@ixdy
Copy link
Member

ixdy commented Nov 19, 2015

Yeah, I'm seeing lots of pods failures today and I don't know why.

@k8s-bot e2e test this

@k8s-bot
Copy link

k8s-bot commented Nov 19, 2015

GCE e2e build/test failed for commit afa12c5.

@wojtek-t
Copy link
Member

@k8s-bot e2e test this please

@k8s-bot
Copy link

k8s-bot commented Nov 19, 2015

GCE e2e test build/test passed for commit afa12c5.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 19, 2015
@k8s-github-robot k8s-github-robot merged commit 3dd04f9 into kubernetes:master Nov 19, 2015
@wonderfly wonderfly deleted the separate_slow_jobs_for_trusty branch November 24, 2015 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants