Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change htmlpreview links: change HEAD to blob/HEAD, and add "blob" in versioned-docs.sh #17381

Merged
merged 1 commit into from
Nov 20, 2015

Conversation

caesarxuchao
Copy link
Member

We want to make the url after the htmlprefix to be valid, so that we can run a link check on that url.

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 17, 2015
@nikhiljindal
Copy link
Contributor

LGTM, thanks!

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e build/test failed for commit 0c913ed.

@caesarxuchao
Copy link
Member Author

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e test build/test passed for commit 0c913ed.

@eparis
Copy link
Contributor

eparis commented Nov 20, 2015

docs only adding e2e-not-required label to get it through the submit queue faster.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 20, 2015
@k8s-github-robot k8s-github-robot merged commit d25cffe into kubernetes:master Nov 20, 2015
@caesarxuchao caesarxuchao deleted the add-blob branch May 12, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants