Small readability improvements in Kubelet #17349
Conversation
…variable in kubelet cmd. Remove comment requesting modification of mesos contrib file, dependencies should be maintained in unit tests
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
|
@smarterclayton Did I do something wrong in the PR? Is it too small? I wanted to get familiar with the process before I attempted larger modifications. |
|
No you did not - just on PTO. Transferring you to someone with more bandwidth. |
|
@k8s-bot ok to test. @peterlamar sorry for slow review (we are amidst the holidays). I'll take a look today. |
|
Thanks @mikedanese ! |
|
GCE e2e build/test failed for commit aef7af1. |
mikedanese
added
the
lgtm
|
@k8s-bot ok tot test |
|
@k8s-bot test this |
|
GCE e2e test build/test passed for commit aef7af1. |
Small readability improvements in Kubelet
Rename kubelet variable pods to maxPods in kubelet pkg to match corresponding maxPods variable in cmd/kubelet/server.go.
Remove comment requesting modification of mesos contrib file, dependencies such as this are maintained in unit tests