Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemonset shouldn't place onto unschedulable nodes #17318

Merged
merged 1 commit into from
Nov 18, 2015

Conversation

mikedanese
Copy link
Member

Fixes #17297

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 16, 2015

GCE e2e test build/test passed for commit f674109.

@mikedanese mikedanese closed this Nov 16, 2015
@mikedanese mikedanese reopened this Nov 16, 2015
@ashcrow
Copy link
Contributor

ashcrow commented Nov 16, 2015

👍 Looks good to me!

@davidopp
Copy link
Member

LGTM

@davidopp davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2015
@paralin
Copy link
Contributor

paralin commented Nov 17, 2015

Did the mergebot die or something? :)

@roberthbailey
Copy link
Contributor

@paralin it isn't merging anything because the scalability tests are not currently passing. See the "Google Internal e2e" tab on http://submit-queue.k8s.io/

ArtfulCoder added a commit that referenced this pull request Nov 18, 2015
daemonset shouldn't place onto unschedulable nodes
@ArtfulCoder ArtfulCoder merged commit a63711c into kubernetes:master Nov 18, 2015
@mikedanese mikedanese deleted the ds-fix branch November 18, 2015 23:33
@bgrant0607
Copy link
Member

This PR prevents us from using DaemonSet for the things we want to use it for.

@mikedanese
Copy link
Member Author

I agree. This was a quick fix for pathological behavior because we don't have he correct configuration knobs but this will be reverted before DaemonSet leaves alpha. Is 2 of #17297 (comment) preferable as a short term fix?

@paralin
Copy link
Contributor

paralin commented Nov 19, 2015

@bgrant0607 as Mike says it didn't work properly anyway, so this is a good fix to make things at least work without errors as an interim until there's a better solution.

@bgrant0607
Copy link
Member

@mikedanese If this gets reverted before DaemonSet graduates to Beta, I'm fine with that. Please add that to #15310.

For self-hosted clusters, (2) is what we want. The master node should be configured like the other nodes.

For clusters where the master isn't on the same network, such as GKE, I agree it doesn't make as much sense.

Perhaps we can leverage #17151 / #17190 to control where daemon pods land by default without needing the full node admission control matrix described in #3885, since this really is more about node selection than schedulability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.