Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve describe for LimitRange resource based on user feedback #17255

Merged

Conversation

derekwaynecarr
Copy link
Member

Technical debt that needed to be cleaned up.

User feedback has requested that we add the word default for clarity.

I agree.

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 13, 2015

GCE e2e build/test failed for commit 1383152.

@derekwaynecarr
Copy link
Member Author

@k8s-bot test this please.

@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e build/test failed for commit 1383152.

@smarterclayton smarterclayton added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cla: yes labels Nov 17, 2015
@derekwaynecarr
Copy link
Member Author

@k8s-bot test this.

@k8s-bot
Copy link

k8s-bot commented Nov 19, 2015

GCE e2e test build/test passed for commit 1383152.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Nov 22, 2015

GCE e2e test build/test passed for commit 1383152.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 22, 2015
@k8s-github-robot k8s-github-robot merged commit 68d6918 into kubernetes:master Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants