allow wrapped binaries to use a configurable image as the base image #17194
Conversation
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
mikedanese
force-pushed
the
configure-baseimage
branch
from
c98f65e to
fa59c31
Compare
|
GCE e2e test build/test passed for commit fa59c312b633d89b1d947b1357f16354861d4d47. |
| @@ -737,27 +739,36 @@ function kube::release::sha1() { | |||
| function kube::release::create_docker_images_for_server() { | |||
There was a problem hiding this comment.
While you're at it, document the args this function takes. (See kube::release::gcs::publish_ci.)
|
LGTM with nits. |
mikedanese
force-pushed
the
configure-baseimage
branch
from
fa59c31 to
d68c36a
Compare
|
GCE e2e test build/test passed for commit d68c36a. |
ikehz
added
the
lgtm
|
LGTM. |
|
Continuous integration appears to have missed, closing and re-opening to trigger it |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test failed for commit d68c36a. |
|
@k8s-bot ok to test |
|
GCE e2e build/test failed for commit d68c36a. |
|
@k8s-bot test this please |
|
GCE e2e test build/test passed for commit d68c36a. |
|
@k8s-bot unit test this please |
|
@k8s-bot ok to test |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
|
GCE e2e build/test failed for commit d68c36a. |
I'm attempting to dockerize kube-proxy, and failing since it requires iptables. This will allow me to use a custom base image to wrap kube-proxy.
@ihmccreery related to build. Do you mind reviewing?