Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run kube-proxy in a static pod #17121

Merged
merged 1 commit into from
Nov 20, 2015
Merged

run kube-proxy in a static pod #17121

merged 1 commit into from
Nov 20, 2015
+272 −257

Conversation

mikedanese
Copy link
Member

will help to migrate it to running in a deamonset

Fixes #16799

@k8s-github-robot
Copy link

Labelling this PR as size/XL

@k8s-github-robot k8s-github-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 11, 2015
@mikedanese mikedanese assigned mikedanese and unassigned zmerlynn Nov 11, 2015
@mikedanese mikedanese force-pushed the kube-proxy-static branch 4 times, most recently from d79060f to 6e2e225 Compare November 13, 2015 18:30
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2015
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2015
@mikedanese mikedanese closed this Nov 16, 2015
@mikedanese mikedanese reopened this Nov 16, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e test build/test passed for commit cd3e9819ed5fe7f8a7b2a3fec40170428b198121.

@mikedanese mikedanese assigned zmerlynn and unassigned mikedanese Nov 17, 2015
@mikedanese
Copy link
Member Author

@zmerlynn @davidopp @roberthbailey not sure who should review this but it's ready.

@mikedanese
Copy link
Member Author

Might be a good time to spread the salt {knowledge,review burden} beyond just Zach.

zmerlynn
zmerlynn reviewed Nov 17, 2015
View reviewed changes
build/common.sh
@@ -99,6 +99,7 @@ readonly KUBE_DOCKER_WRAPPED_BINARIES=(
kube-apiserver,busybox
kube-controller-manager,busybox
kube-scheduler,busybox
kube-proxy,beta.gcr.io/google_containers/debian-iptables:v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/beta.//, right? (#16824)

@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e build/test failed for commit 778c04d2ce72d4b75b96e03b9ece9fec9364fbd8.

@zmerlynn
Copy link
Member

@k8s-bot e2e test this

@k8s-bot
Copy link

k8s-bot commented Nov 18, 2015

GCE e2e test build/test passed for commit 778c04d2ce72d4b75b96e03b9ece9fec9364fbd8.

@mikedanese
Copy link
Member Author

@zmerlynn addressed comments.

@zmerlynn
Copy link
Member

LGTM

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 19, 2015

GCE e2e build/test failed for commit 1d9d11c.

@zmerlynn
Copy link
Member

@k8s-bot e2e test this

@k8s-bot
Copy link

k8s-bot commented Nov 19, 2015

GCE e2e test build/test passed for commit 1d9d11c.

@wojtek-t
Copy link
Member

@mikedanese - awesome; thanks for doing this!
@fgrzadkowski - FYI

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e test build/test passed for commit 1d9d11c.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 20, 2015
Merge pull request #17121 from mikedanese/kube-proxy-static
ac65782 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit ac65782 into kubernetes:master Nov 20, 2015
@ixdy ixdy mentioned this pull request Nov 20, 2015
Closed
@wojtek-t wojtek-t mentioned this pull request Nov 20, 2015
Closed
@mikedanese mikedanese deleted the kube-proxy-static branch November 30, 2015 17:12
@mikedanese mikedanese mentioned this pull request Nov 30, 2015
Closed
@dalanlan dalanlan mentioned this pull request Dec 1, 2015
Closed
@yujuhong yujuhong mentioned this pull request Dec 9, 2015
Closed
@andyzheng0831 andyzheng0831 mentioned this pull request Dec 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mikedanese @k8s-github-robot @k8s-bot @zmerlynn @wojtek-t @roberthbailey @k8s-teamcity-mesosphere @googlebot