Change order of CORS and authenticatedHandler for secureHandler. #17093
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
k8s-github-robot
added
the
size/S
|
Labelling this PR as size/S |
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
I signed it! |
|
CLAs look good, thanks! |
| @@ -738,6 +729,17 @@ func (m *Master) init(c *Config) { | |||
| handler = authenticatedHandler | |||
| } | |||
|
|
|||
| if len(c.CorsAllowedOriginList) > 0 { | |||
There was a problem hiding this comment.
Please add a comment explaining why this needs to happen before the auth check.
|
comment addressed |
lavalamp
added
the
lgtm
|
LGTM, thanks! |
|
@k8s-bot ok to test |
|
Continuous integration appears to have missed, closing and re-opening to trigger it |
|
GCE e2e test build/test passed for commit 6d94dd1. |
|
@k8s-bot unit test this please |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test failed for commit 6d94dd1. |
|
@k8s-bot test this please |
|
GCE e2e test build/test passed for commit 6d94dd1. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 6d94dd1. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Per discussion in #16431 . This PR change the handler wrapping order for secureHandler.
Fixes #16431