Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Strip more comments from instance user-data #17091

Merged
merged 1 commit into from
Dec 10, 2015
Merged

AWS: Strip more comments from instance user-data #17091

merged 1 commit into from
Dec 10, 2015

Conversation

justinsb
Copy link
Member

To stay under the 16KB limit

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 11, 2015

GCE e2e test build/test passed for commit bf32b5e4ac6fbb766d07aaecbdca079e7a05e24b.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2015
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2015
@wojtek-t
Copy link
Member

@justinsb - can you please rebase?

1 similar comment
@wojtek-t
Copy link
Member

@justinsb - can you please rebase?

@wojtek-t
Copy link
Member

@justinsb - friendly ping - can you please rebase this PR?

@wojtek-t
Copy link
Member

@justinsb - can you please rebase?

1 similar comment
@wojtek-t
Copy link
Member

@justinsb - can you please rebase?

@wojtek-t
Copy link
Member

@justinsb - can you please rebase this PR?

@justinsb
Copy link
Member Author

justinsb commented Dec 8, 2015

Rebased.... ironically I think it was a conflict against my own PR.

Sorry for the ridiculous delay!

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 8, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 8, 2015

GCE e2e build/test failed for commit 428e415.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2015
@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 10, 2015
Merge pull request #17091 from justinsb/aws_strip_comments
d8cd5fa 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit d8cd5fa into kubernetes:master Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@justinsb @k8s-github-robot @k8s-bot @wojtek-t @k8s-teamcity-mesosphere @googlebot @brendandburns