Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use docker-machine for k8petstore on linux #17075

Merged
merged 1 commit into from
Nov 12, 2015
Merged

don't use docker-machine for k8petstore on linux #17075

merged 1 commit into from
Nov 12, 2015

Conversation

jeffvance
Copy link
Contributor

Fixes #17063

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Nov 10, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Nov 10, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 10, 2015
@@ -16,15 +16,20 @@

!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line? (It's not a shebang.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed that in next fix

@zmerlynn
Copy link
Member

@jeffvance: BTW, if you talk to @smarterclayton, there's a way to get @googlebot to stop hassling you as a RedHatter (which you clearly are).

@zmerlynn
Copy link
Member

@k8s-bot ok to test

@k8s-bot
Copy link

k8s-bot commented Nov 10, 2015

GCE e2e build/test failed for commit 95802c193ea3da06cedb071867f505ef14fe2e9a.

@jayunit100
Copy link
Member

UPDATE removing my "Looks good" since tests are failing , will look further.........

I also suggested to jeff that we need to stop building redis from scratch... Rebuilding redis containers against a specific OS is unnecessary.

@jeffvance i think you can also fix the !/bin/bash easily in this PR.

Thanks!

@k8s-bot
Copy link

k8s-bot commented Nov 11, 2015

GCE e2e test build/test passed for commit 6cdae0c7fc5b13db5e279946b2feecea372e590f.

@jayunit100
Copy link
Member

I've reviewed and tested this... This looks good to me.

Maybe we can get a quick LGTM from the commiters?

@jeffvance
Copy link
Contributor Author

@googlebot I signed it!

@jeffvance
Copy link
Contributor Author

@googlebot I signed it !

@googlebot
Copy link

CLAs look good, thanks!

@pmorie pmorie added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 11, 2015

GCE e2e test build/test passed for commit 5ccf073.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 12, 2015
@k8s-github-robot k8s-github-robot merged commit 53c39d7 into kubernetes:master Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants