-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't use docker-machine for k8petstore on linux #17075
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Labelling this PR as size/M |
@@ -16,15 +16,20 @@ | |||
|
|||
!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this line? (It's not a shebang.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, fixed that in next fix
@jeffvance: BTW, if you talk to @smarterclayton, there's a way to get @googlebot to stop hassling you as a RedHatter (which you clearly are). |
@k8s-bot ok to test |
GCE e2e build/test failed for commit 95802c193ea3da06cedb071867f505ef14fe2e9a. |
UPDATE removing my "Looks good" since tests are failing , will look further......... I also suggested to jeff that we need to stop building redis from scratch... Rebuilding redis containers against a specific OS is unnecessary. @jeffvance i think you can also fix the Thanks! |
GCE e2e test build/test passed for commit 6cdae0c7fc5b13db5e279946b2feecea372e590f. |
I've reviewed and tested this... This looks good to me. Maybe we can get a quick LGTM from the commiters? |
@googlebot I signed it! |
@googlebot I signed it ! |
CLAs look good, thanks! |
GCE e2e test build/test passed for commit 5ccf073. |
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
Automatic merge from submit-queue |
Auto commit by PR queue bot
Fixes #17063