@ncdc ptal

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@csrwng - what is the motivation for this change?

@wojtek-t 2 reasons: 1) the default glog format includes module and line number which is great for a debug log but not for interactive command output and 2) it makes the portforward command more usable from other commands if those commands can supply the output streams.

@k8s-bot this this

@k8s-bot add to whitelist

@csrwng not sure what the exact failures are, given the build log is missing. You may want to download all the individual JUnit test artifacts to search for the failure :-/

@ixdy this has failed e2e 3 times but there's no build log. Any ideas what's going on?

@ncdc see #17282

@csrwng finally got the failure info:

• Failure [33.408 seconds]
Port forwarding
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/portforward.go:240
  With a server that expects a client request
  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/portforward.go:203
    should support a client that connects, sends data, and disconnects [Conformance] [It]
    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/portforward.go:202

    Nov 17 09:11:49.279: Failed to parse kubectl port-forward output: E1117 09:11:49.278868    9382 portforward.go:207] Unable to create listener: Error listen tcp6 [::1]:38007: bind: cannot assign 

    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/portforward.go:104

Do you think your output changes would cause this? Can you try to run this e2e locally?

@ncdc yes, I'll try it locally later today. Thank you much for getting the log of the failure. And yes, it looks like the e2e test is expecting the old output of the portforward command, so it needs to be fixed.

Fixed the e2e test to expect output on stdout instead of stderr

LGTM. @liggitt care to sanity check?

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

PR needs rebase

We need to decide if this is in or out ASAP.

I think this can wait until 1.3. You ok with that @csrwng @liggitt ?

yeah

that's fine with me... will rebase as well

Please rebase and push

rebased

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit 55114ef.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue